Skip to content

feat(insights): add endpoint to create/delete starred transactions #89330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Apr 10, 2025

Follow up to #89203
In insights overview pages, we want individual users to be able to star their own transactions. This PR creates an endpoint to allow users to do so

@DominikB2014 DominikB2014 requested a review from a team April 10, 2025 19:55
@DominikB2014 DominikB2014 requested a review from a team as a code owner April 10, 2025 19:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/insights/endpoints/starred_segments.py 91.48% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #89330    +/-   ##
========================================
  Coverage   87.70%   87.70%            
========================================
  Files       10140    10144     +4     
  Lines      572872   573276   +404     
  Branches    22513    22513            
========================================
+ Hits       502422   502808   +386     
- Misses      70004    70022    +18     
  Partials      446      446            

@DominikB2014 DominikB2014 merged commit 480efb7 into master Apr 11, 2025
60 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-98-add-endpoint-to-update-starred-transactions branch April 11, 2025 20:56
billyvg pushed a commit that referenced this pull request Apr 14, 2025
…89330)

Follow up to #89203
In insights overview pages, we want individual users to be able to star
their own transactions. This PR creates an endpoint to allow users to do
so
DominikB2014 added a commit that referenced this pull request Apr 14, 2025
Adds a new table cell for a starred transaction, this is a v0 version of
this feature. This is to support to user based starred transactions in
EAP. This mainly scaffolds the component, test, styling update and usage
of this cell will come in future PRs.

This feature is dependant on this API change
#89330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants