feat(Codecov): Add tests for datePicker components #89341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Apr 10, 2025
Comment on lines
32
to
38
| ConfigStore.loadInitialData( | ||
| ConfigFixture({ | ||
| user: UserFixture({ | ||
| options: {...UserFixture().options, timezone: 'America/New_York'}, | ||
| }), | ||
| }) | ||
| ); |
There was a problem hiding this comment.
this can be simplified a bit
Suggested change
| ConfigStore.loadInitialData( | |
| ConfigFixture({ | |
| user: UserFixture({ | |
| options: {...UserFixture().options, timezone: 'America/New_York'}, | |
| }), | |
| }) | |
| ); | |
| ConfigStore.set('user', UserFixture({timezone: 'America/New_York'})); |
There was a problem hiding this comment.
you probably don't need to setup the config store at all
scttcper
reviewed
Apr 10, 2025
Comment on lines
23
to
29
| function getComponent(props = {}) { | ||
| return <DateSelector onChange={onChange} {...props} />; | ||
| } | ||
|
|
||
| function renderComponent(props = {}) { | ||
| return render(getComponent(props), {router}); | ||
| } |
There was a problem hiding this comment.
the props types here are {}. Putting <DateSelector onChange={onChange} /> in each test saves pain later
scttcper
reviewed
Apr 10, 2025
Comment on lines
10
to
18
| const {router} = initializeOrg({ | ||
| router: { | ||
| location: { | ||
| pathname: '/codecov/tests/', | ||
| query: {}, | ||
| }, | ||
| params: {}, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
you probably don't need this either
|
Thanks for the feedback @scttcper, agree with your suggestions and got rid of some code |
scttcper
approved these changes
Apr 11, 2025
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Adds tests for the components in #89117. It also moves around those components for better folder structure.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the components in #89117. It also moves around those components for better folder structure.