Skip to content

feat(options): Add a default level of indentation when generating flagpole config #89348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

wedamija
Copy link
Member

Right now, we don't generate any indentation for our outputted flags. This is a little annoying when copying into options automator, since we need one level of indentation there. It's a bit error prone too, because it's easy to miss if you're just pasting in config.

To work around this, just add a fake default top level key, and strip it out from the output.

…gpole config

Right now, we don't generate any indentation for our outputted flags. This is a little annoying when copying into options automator, since we need one level of indentation there. It's a bit error prone too, because it's easy to miss if you're just pasting in config.

To work around this, just add a fake default top level key, and strip it out from the output.
@wedamija wedamija requested review from markstory, GabeVillalobos and a team April 10, 2025 21:34
@wedamija wedamija enabled auto-merge (squash) April 10, 2025 21:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2025
@wedamija wedamija merged commit ccd0495 into master Apr 11, 2025
61 checks passed
@wedamija wedamija deleted the danf/automator-indent-createflag branch April 11, 2025 14:24
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
…gpole config (#89348)

Right now, we don't generate any indentation for our outputted flags.
This is a little annoying when copying into options automator, since we
need one level of indentation there. It's a bit error prone too, because
it's easy to miss if you're just pasting in config.

To work around this, just add a fake default top level key, and strip it
out from the output.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants