feat(options): Add a default level of indentation when generating flagpole config #89348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gpole config Right now, we don't generate any indentation for our outputted flags. This is a little annoying when copying into options automator, since we need one level of indentation there. It's a bit error prone too, because it's easy to miss if you're just pasting in config. To work around this, just add a fake default top level key, and strip it out from the output.
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Apr 11, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
…gpole config (#89348) Right now, we don't generate any indentation for our outputted flags. This is a little annoying when copying into options automator, since we need one level of indentation there. It's a bit error prone too, because it's easy to miss if you're just pasting in config. To work around this, just add a fake default top level key, and strip it out from the output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we don't generate any indentation for our outputted flags. This is a little annoying when copying into options automator, since we need one level of indentation there. It's a bit error prone too, because it's easy to miss if you're just pasting in config.
To work around this, just add a fake default top level key, and strip it out from the output.