Skip to content

feat(uptime): Switch uptime grouptype to use flagpole #89363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/issues/grouptype.py
Original file line number Diff line number Diff line change
@@ -666,6 +666,7 @@ class UptimeDomainCheckFailure(GroupType):
},
"additionalProperties": False,
}
use_flagpole_for_all_features = True


@dataclass(frozen=True)
2 changes: 1 addition & 1 deletion tests/sentry/uptime/consumers/test_results_consumer.py
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ def send_result(
datetime.now(),
)
)
with self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
with self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()):
if consumer is None:
factory = UptimeResultsStrategyFactory(mode=self.strategy_processing_mode)
commit = mock.Mock()
5 changes: 4 additions & 1 deletion tests/sentry/uptime/subscriptions/test_subscriptions.py
Original file line number Diff line number Diff line change
@@ -690,7 +690,10 @@ def test(self, mock_disable_seat):

@mock.patch("sentry.quotas.backend.disable_seat")
def test_disable_failed(self, mock_disable_seat):
with self.tasks(), self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
with (
self.tasks(),
self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()),
):
proj_sub = create_project_uptime_subscription(
self.project,
self.environment,
2 changes: 1 addition & 1 deletion tests/sentry/uptime/test_issue_platform.py
Original file line number Diff line number Diff line change
@@ -119,7 +119,7 @@ def test(self):
uptime_subscription=subscription
)
result = self.create_uptime_result(subscription.subscription_id)
with self.feature(UptimeDomainCheckFailure.build_ingest_feature_name()):
with self.feature(UptimeDomainCheckFailure.build_ingest_flagpole_feature_name()):
create_issue_platform_occurrence(result, project_subscription)
hashed_fingerprint = md5(str(project_subscription.id).encode("utf-8")).hexdigest()
group = Group.objects.get(grouphash__hash=hashed_fingerprint)