Impl. const. eval. for "first bit" numeric built-ins #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
9e8436c to
715d9ca
Compare
ErichDonGubler
added
area: correctness
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
715d9ca to
ff4a61d
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
3 times, most recently
from
1385753 to
fd9c5d2
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
2 times, most recently
from
00765aa to
2b36f65
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
2b36f65 to
9e327e1
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
2 times, most recently
from
3f43c9d to
d5eb8f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
d5eb8f9 to
14ca774
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
14ca774 to
1621b9b
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
1621b9b to
3e23247
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
4 times, most recently
from
c57281f to
31ea912
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
99fe74d to
1a2118f
Compare
ErichDonGubler
commented
Jul 23, 2024
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
1a2118f to
f93f693
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
from
f93f693 to
47a5933
Compare
79 tasks
ErichDonGubler
force-pushed
the
builtins-const-eval-first_bits
branch
2 times, most recently
from
e3293f8 to
f73e616
Compare
teoxoy
force-pushed
the
builtins-const-eval-first_bits
branch
from
f73e616 to
a1e6c86
Compare
|
Just rebased this via GH's UI since it was running into timeouts that got fixed in #6030. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Soft dependency on #5098.
Description
Describe what problem this is solving, and how it's solved.
I think it's self-evident, but I'm happy to write something longer if it's not.
Testing
Explain how this change is tested.
Some testing is evident from changes to Naga's snapshot tests, but there's not full coverage of these. I would accept a request to add tests before merging.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.