[naga wgsl-in] Implement any() and all() during const evaluation #7166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of #4507 . When testing CTS changes for #7035 I noticed we still get quite a few failures in the
webgpu:shader,validation,const_assert,const_assert:constant_expression_assert:*
group due to this.Description
any()
andall()
should be evaluated at constant time.eg naga should transform this shader:
to
Note this already works for the scalar versions of these function as we handle that specially in the WGSL frontend (in commit 3bd2834). This makes us handle vectors args too.
Testing
Added snapshot tests
Checklist
cargo fmt
.cargo clippy
. If applicable, add:cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.