Skip to content

vulkan: support noncontiguous rms_norm #13031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

jeffbolznv
Copy link
Collaborator

Fixes #12956.

@stduhpf I didn't run the deepseek model, I just used test-backend-ops. Can you check whether deepseek works with this PR?

@jeffbolznv jeffbolznv requested a review from 0cc4m April 20, 2025 04:44
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Apr 20, 2025
@stduhpf
Copy link
Contributor

stduhpf commented Apr 20, 2025

Yes, this fixes Deepseek (V2 lite at least).

Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0cc4m 0cc4m merged commit 6616820 into ggml-org:master Apr 20, 2025
48 checks passed
colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025
pockers21 pushed a commit to pockers21/llama.cpp that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eval bug: Deepseek V2 Lite no longer working with Vulkan (assert fail during tg)
3 participants