quantize: improve pattern matching for allowed tensors #13033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for shotgun approach @ggerganov / @slaren / @ngxson, I'm not sure what the proper process to request a review is. This PR addresses #12511 deficiencies. Happy to close or move to draft if it's not suitable for merging |
slaren
reviewed
May 4, 2025
| @@ -1,5 +1,6 @@ | |||
| #include "common.h" | |||
| #include "llama.h" | |||
| #include "llama-quant.h" | |||
There was a problem hiding this comment.
We should avoid including private headers.
There was a problem hiding this comment.
I'll update as suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements @slaren's regex matching recommendation for allowed tensors. For example:
--tensor-type attn=q4_kwill now apply to all tensors named *attn*