cli : Support "-" for stdout like stdin #3050
Conversation
danielzgtg
force-pushed
the
feat/fd
branch
4 times, most recently
from
755ccbb to
03877f5
Compare
|
It's strange that the unrelated |
This is unrelated to this PR, it was fixed by #3084. |
There was a problem hiding this comment.
I tried this using json output format and stdout using the following command:
../build/bin/whisper-cli -m models/ggml-tiny.en.bin -f samples/jfk.wav -oj -of - -np 2> /dev/null | jq -c '.transcription[].text'
" And so my fellow Americans ask not what your country can do for you, ask what you can do for your country."Without redirecting stderr the following will be printed as output to the console:
output_json: saving output to '/dev/stdout'
" And so my fellow Americans ask not what your country can do for you, ask what you can do for your country."It might be nice to not have to specify the redirect of stderr when using stdout. This was not something that was introduced by this PR but I think it would nice to perhaps have a check and not output this log message in this case.
This changes examples/cli/cli.cpp to be like examples/common-whisper.cpp. "-of -" can be specified (or this can be inferred from "-" as the input file) to output to stdout. This is useful for piping to other applications. Log fname_out consistently when not stdout - Terminals have stdout=stderr, so remove the message before successful output to ease copying - Don't affect actual error messages - Move opening the ofstream into the factory, fixing missing open and/or error messages in output_score/output_wts - Fix struct naming convention Closes ggml-org#3048
|
Squashed and rebased on top of latest master to see if that fixes CI |
This changes
examples/cli/cli.cppto be likeexamples/common-whisper.cpp.-of -can be specified (or this can be inferred from-as the input file) to output to stdout. This is useful for piping to other applications.Also fixed
output_scoreandoutput_wtsnot outputting some logging messages thatoutput_jsondoes.Closes #3048