Flat bindings for non C++ use #3104
Open
+467
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.cpp into bindings_flat
|
No problem, just wanted to alert you to the fact there was a potential issue with the MSVC stuff There's still actually something small wrong with my PR - it only affects examples though and ONLY with my new DEFINE, I'll have a look at it in a bit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's only of use to people using other languages the code is only used if -DBINDINGS_FLAT is passed to cmake
If BINDINGS_FLAT is not present then the end ressult is same as master
It was necessary to disable the recent MSVC warnings commit as this broke GGML_CPU_ALL_VARIANTS