Skip to content

home/hero.html: fix download link #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

ttaylorr
Copy link
Contributor

Prior to v2.5.0, Git LFS named packaged release artifacts as:

git-lfs-darwin-amd64-2.4.0.tar.gz

and etc., for combinations of OS, architecture, version, and archival
format.

In v2.5.0, we began naming those same release artifacts as:

git-lfs-darwin-amd64-v2.5.0.tar.gz

Noting that there is now a 'v' prefix for the version number. In lieu of
changing this back to the sans-'v' format, let's keep this and continue
to name versions as-is from here going forward.

This will help alleviate some whiplash experienced by packaging
maintainers who have updated scripts to account for this new name, and
it will be easier to maintain in Git LFS's somewhat-complicated
Makefile.

So, given that this change is here to stay (and we only ever increase
the version number ;-) ), let's update the link on the website to
download the appropriate thing, and not 404.

Closes: #32.

/cc @git-lfs/core

Prior to v2.5.0, Git LFS named packaged release artifacts as:

    git-lfs-darwin-amd64-2.4.0.tar.gz

and etc., for combinations of OS, architecture, version, and archival
format.

In v2.5.0, we began naming those same release artifacts as:

    git-lfs-darwin-amd64-v2.5.0.tar.gz

Noting that there is now a 'v' prefix for the version number. In lieu of
changing this back to the sans-'v' format, let's keep this and continue
to name versions as-is from here going forward.

This will help alleviate some whiplash experienced by packaging
maintainers who have updated scripts to account for this new name, and
it will be easier to maintain in Git LFS's somewhat-complicated
Makefile.

So, given that this change is here to stay (and we only ever increase
the version number ;-) ), let's update the link on the website to
download the appropriate thing, and not 404.
@ttaylorr ttaylorr merged commit 35e52ce into master Jul 30, 2018
@ttaylorr ttaylorr deleted the ttaylorr/fix-download-link branch July 30, 2018 15:47
ttaylorr added a commit that referenced this pull request Jul 30, 2018
In [1], a few instances of referring to newer releases of Git LFS were
updated to point at the correct location(s). This patch gets the rest of
them, too.

[1]: 35e52ce (Merge pull request #33 from
     git-lfs/ttaylorr/fix-download-link, 2018-07-30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link broken
1 participant