[Stalled] FindCommitByChangesetId should look in a specific Tfs branch #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,8 @@ public int Run(string id) | |||
| long changesetId; | |||
| if(!long.TryParse(id, out changesetId)) | |||
| throw new GitTfsException("error: wrong format for changeset id..."); | |||
| var sha = _globals.Repository.FindCommitHashByChangesetId(changesetId); | |||
| //TODO | |||
| var sha = _globals.Repository.FindCommitHashByChangesetId(changesetId, "TODO"); | |||
There was a problem hiding this comment.
I need to find a solution for that...
There was a problem hiding this comment.
Make FindCommitsByChangesetId, which will find all matching commits on ALL branches (remove c.Message.Contains(tfsPath) and show warning or prompt to the user if there are more than one commit/branch.
|
I've created a pull request with TODO resolution pmiossec#9 |
pmiossec
force-pushed
the
find_commit_in_specific_branch
branch
from
2c83d23 to
20b364c
Compare
pmiossec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be the first step toward fixing #769...
Tests appreciated ;)
cc @gufi