Skip to content

Python: mass enable diff-informed data flow none() location overrides #19797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
+8 −0
Merged

Python: mass enable diff-informed data flow none() location overrides #19797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...on/ql/src/experimental/Security/CWE-327/Azure/UnsafeUsageOfClientSideEncryptionVersion.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ private module AzureBlobClientConfig implements DataFlow::StateConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node sink) { none() }
}

module AzureBlobClientFlow = DataFlow::GlobalWithState<AzureBlobClientConfig>;
Expand Down
2 changes: 2 additions & 0 deletions python/ql/src/experimental/Security/CWE-346/CorsBypass.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ module CorsBypassConfig implements DataFlow::ConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node sink) { none() }
}

module CorsFlow = TaintTracking::Global<CorsBypassConfig>;
Expand Down
2 changes: 2 additions & 0 deletions python/ql/src/experimental/Security/UnsafeUnpackQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ module UnsafeUnpackConfig implements DataFlow::ConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node sink) { none() }
}

/** Global taint-tracking for detecting "UnsafeUnpacking" vulnerabilities. */
Expand Down
2 changes: 2 additions & 0 deletions python/ql/src/experimental/semmle/python/security/LdapInsecureAuth.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ private module LdapInsecureAuthConfig implements DataFlow::ConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node sink) { none() }
Copy link
Preview

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This override is identical in multiple config modules; consider extracting a shared mixin or base module to provide the default none() override and reduce duplication.

Copilot uses AI. Check for mistakes.

}

/** Global taint-tracking for detecting "LDAP insecure authentications" vulnerabilities. */
Expand Down