Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

sergeibbb · 2025-01-17T02:31:52Z

follow up of #3923 and #3934

Description

Adds search by URL for GitLab Self Managed to the Launchpad
Adds search by URL for GitHub Enterprise to the Launchpad

Checklist

I have followed the guidelines in the Contributing document
My changes follow the coding style of this project
My changes build without any errors or warnings
My changes have been formatted and linted
My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

(#3942)

sergeibbb · 2025-01-17T02:40:28Z

@axosoft-ramint

Now it doesn't harm users. Just search by URL doesn't work for self hosted GitHub and GitLab. That is why I suppose this PR can be merged after the release as a follow-up.

I haven't changed the CHANGELOG yet, because if we decide to merge before the release, it will be covered by general notes of adding self-hosted GitLab and GitHub.

Also, I've noticed that GitLab's and GitHub's methods are similar: they get a value without provider field and then extend it with this.id. I wanted to move it to the base class, but the return type is incompatible with Jira.

(#3942)

sergeibbb · 2025-04-11T12:31:53Z

@axosoft-ramint

i've fixed the conflicts here and did some testing

(#3942)

axosoft-ramint

Thanks for putting this together. Just a few very minor suggestions, then it looks good to me after.

axosoft-ramint · 2025-04-16T23:17:04Z

CHANGELOG.md

@@ -162,6 +162,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 - Fixes [#3940](https://github.com/gitkraken/vscode-gitlens/issues/3940) - Commit Details: issue autolinks can disappear after enrichment
 - Fixes [#4035](https://github.com/gitkraken/vscode-gitlens/issues/4035) - Repo is lost when "Generate commit" is requested

+#### Added
+
+- Searches by URL for self hosted GitHub and GitLab on Launchpad


Suggested change

- Searches by URL for self hosted GitHub and GitLab on Launchpad

- Adds the ability to search for GitHub Enterprise and GitLab Self-Managed pull requests by URL in the main step of Launchpad

axosoft-ramint · 2025-04-16T23:21:48Z

src/plus/integrations/providers/github/github.utils.ts

 	return getGitHubPullRequestIdentityFromMaybeUrl(url) != null;
 }

 export function getGitHubPullRequestIdentityFromMaybeUrl(
 	search: string,
-): (PullRequestUrlIdentity & { provider: HostingIntegrationId.GitHub }) | undefined {
+): Omit<PullRequestUrlIdentity, 'provider'> | undefined {


What if we just updated this function to require, in addition to the search parameter, an id parameter of type GitHubRelatedIntegrationIds? Then you don't need to add on the id afterwards in the integration fn and can directly call this with its id.

Both ways achieve the same effect, maybe just easier not to have to shallow-clone the object afterwards, and you don't need to apply Omit on the return type either.

And I would say the same thing for getGitLabPullRequestIdentityFromMaybeUrl.

@axosoft-ramint
fixed

axosoft-ramint · 2025-04-16T23:22:10Z

src/plus/integrations/providers/gitlab/gitlab.utils.ts

@@ -11,7 +10,7 @@ export function isMaybeGitLabPullRequestUrl(url: string): boolean {

 export function getGitLabPullRequestIdentityFromMaybeUrl(
 	search: string,
-): (PullRequestUrlIdentity & { provider: HostingIntegrationId.GitLab }) | undefined {
+): Omit<PullRequestUrlIdentity, 'provider'> | undefined {


See above comment on getGitHubPullRequestIdentityFromMaybeUrl

@axosoft-ramint
fixed

(#3942)

sergeibbb added a commit that referenced this pull request Jan 17, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

aac1101

(#3942)

sergeibbb added a commit that referenced this pull request Jan 17, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

261dc44

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 0d463ae to 261dc44 Compare January 17, 2025 02:33

sergeibbb requested a review from axosoft-ramint January 17, 2025 02:40

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

083e623

(#3942)

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

d3e3678

(#3942)

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Mentions search by URL in changelog

e4ccda5

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 261dc44 to e4ccda5 Compare January 23, 2025 11:23

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

ea81553

(#3942)

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

a49f489

(#3942)

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Mentions search by URL in changelog

dd4e3ca

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from e4ccda5 to dd4e3ca Compare January 23, 2025 11:24

sergeibbb requested review from axosoft-ramint and removed request for axosoft-ramint January 23, 2025 11:24

sergeibbb added a commit that referenced this pull request Jan 23, 2025

Mentions search by URL in changelog

54f2e07

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from dd4e3ca to 54f2e07 Compare January 23, 2025 11:26

sergeibbb added a commit that referenced this pull request Apr 11, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

0266271

(#3942)

sergeibbb added a commit that referenced this pull request Apr 11, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

dd33503

(#3942)

sergeibbb added a commit that referenced this pull request Apr 11, 2025

Mentions search by URL in changelog

cfa54e2

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 54f2e07 to cfa54e2 Compare April 11, 2025 12:19

sergeibbb added this to the 17.1 milestone Apr 11, 2025

sergeibbb assigned axosoft-ramint Apr 11, 2025

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

d68ef97

(#3942)

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

5b467bf

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from cfa54e2 to 25b7a5e Compare April 14, 2025 09:41

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Mentions search by URL in changelog

25b7a5e

(#3942)

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

f8bbeb4

(#3942)

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

a8e607c

(#3942)

sergeibbb added a commit that referenced this pull request Apr 14, 2025

Mentions search by URL in changelog

643b569

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 25b7a5e to 643b569 Compare April 14, 2025 10:04

axosoft-ramint assigned sergeibbb and unassigned axosoft-ramint Apr 16, 2025

axosoft-ramint reviewed Apr 16, 2025

View reviewed changes

sergeibbb added 3 commits April 17, 2025 13:03

Adds search by URL for GitHub Enterprise to the Launchpad

711b2b7

(#3942)

Adds search by URL for GitLab Self Managed to the Launchpad

416c6f9

(#3942)

Mentions search by URL in changelog

2148232

(#3942)

sergeibbb force-pushed the feature/search-by-url-for-self-hosted branch from 643b569 to 2148232 Compare April 17, 2025 11:03

sergeibbb requested a review from axosoft-ramint April 17, 2025 11:06

axosoft-ramint approved these changes Apr 17, 2025

View reviewed changes

sergeibbb merged commit 2f2609b into main Apr 17, 2025
3 checks passed

sergeibbb added a commit that referenced this pull request Apr 17, 2025

Adds search by URL for GitHub Enterprise to the Launchpad

bf8bf71

(#3942)

sergeibbb added a commit that referenced this pull request Apr 17, 2025

Adds search by URL for GitLab Self Managed to the Launchpad

2967a4a

(#3942)

sergeibbb deleted the feature/search-by-url-for-self-hosted branch April 17, 2025 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

sergeibbb commented Jan 17, 2025 •

edited

Loading

sergeibbb commented Jan 17, 2025 •

edited

Loading

sergeibbb commented Apr 11, 2025 •

edited

Loading

axosoft-ramint left a comment •

edited

Loading

axosoft-ramint Apr 16, 2025

sergeibbb Apr 17, 2025

axosoft-ramint Apr 16, 2025 •

edited

Loading

sergeibbb Apr 17, 2025

axosoft-ramint Apr 16, 2025

sergeibbb Apr 17, 2025

	- Searches by URL for self hosted GitHub and GitLab on Launchpad
	- Adds the ability to search for GitHub Enterprise and GitLab Self-Managed pull requests by URL in the main step of Launchpad

Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

Searches by URL for self hosted GitHub and GitLab on Launchpad #3942

Conversation

sergeibbb commented Jan 17, 2025 • edited Loading

Description

Checklist

sergeibbb commented Jan 17, 2025 • edited Loading

sergeibbb commented Apr 11, 2025 • edited Loading

axosoft-ramint left a comment • edited Loading

Choose a reason for hiding this comment

axosoft-ramint Apr 16, 2025

Choose a reason for hiding this comment

sergeibbb Apr 17, 2025

Choose a reason for hiding this comment

axosoft-ramint Apr 16, 2025 • edited Loading

Choose a reason for hiding this comment

sergeibbb Apr 17, 2025

Choose a reason for hiding this comment

axosoft-ramint Apr 16, 2025

Choose a reason for hiding this comment

sergeibbb Apr 17, 2025

Choose a reason for hiding this comment

sergeibbb commented Jan 17, 2025 •

edited

Loading

sergeibbb commented Jan 17, 2025 •

edited

Loading

sergeibbb commented Apr 11, 2025 •

edited

Loading

axosoft-ramint left a comment •

edited

Loading

axosoft-ramint Apr 16, 2025 •

edited

Loading