-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adds IssueOrPullRequestType
to cache keys for issue/PR retrieval
#4233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55a42b3
to
a03056a
Compare
a03056a
to
fffa889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't repro my original issue on this branch, so it seems to work. I would request, however, that you use IssueOrPullRequestType
rather than AutolinkType
so we can keep AutolinkType
internal to the autolink domain where we can (and also because IssueOrPullRequestType
is the type of the params being passed down from the integration in the places I checked).
fffa889
to
628fed7
Compare
Fixed |
AutolinkType
to cache keys for issue/PR retrievalIssueOrPullRequestType
to cache keys for issue/PR retrieval
628fed7
to
cb2026e
Compare
solves #4193
Description
Adds
IssueOrPullRequestType
to cache keys for issue/PR retrieval preventing potential cache collisions.Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses