Skip to content

Adds IssueOrPullRequestType to cache keys for issue/PR retrieval #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Apr 14, 2025

solves #4193

Description

Adds IssueOrPullRequestType to cache keys for issue/PR retrieval preventing potential cache collisions.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb added a commit that referenced this pull request Apr 14, 2025
preventing potential cache collisions.
(#4193, #4233)
@sergeibbb sergeibbb force-pushed the bug/4193-fix-pr-autoinks-bitbucket branch from 55a42b3 to a03056a Compare April 14, 2025 13:11
sergeibbb added a commit that referenced this pull request Apr 14, 2025
preventing potential cache collisions.
(#4193, #4233)
@sergeibbb sergeibbb force-pushed the bug/4193-fix-pr-autoinks-bitbucket branch from a03056a to fffa889 Compare April 14, 2025 13:44
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't repro my original issue on this branch, so it seems to work. I would request, however, that you use IssueOrPullRequestType rather than AutolinkType so we can keep AutolinkType internal to the autolink domain where we can (and also because IssueOrPullRequestType is the type of the params being passed down from the integration in the places I checked).

sergeibbb added a commit that referenced this pull request Apr 17, 2025
preventing potential cache collisions.
(#4193, #4233)
@sergeibbb sergeibbb force-pushed the bug/4193-fix-pr-autoinks-bitbucket branch from fffa889 to 628fed7 Compare April 17, 2025 10:22
@sergeibbb
Copy link
Member Author

@axosoft-ramint

I would request, however, that you use IssueOrPullRequestType rather than AutolinkType

Fixed

@sergeibbb sergeibbb changed the title Adds AutolinkType to cache keys for issue/PR retrieval Adds IssueOrPullRequestType to cache keys for issue/PR retrieval Apr 17, 2025
@sergeibbb sergeibbb force-pushed the bug/4193-fix-pr-autoinks-bitbucket branch from 628fed7 to cb2026e Compare April 17, 2025 10:24
@sergeibbb sergeibbb merged commit d798bfd into main Apr 17, 2025
@sergeibbb sergeibbb deleted the bug/4193-fix-pr-autoinks-bitbucket branch April 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR autolink patterns like pull request # link to an issue of that number instead
2 participants