Use gitoxide
in get_commits_info
and get_commit_info
#2643
+108
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From<gix::ObjectId>
forCommitId
gitoxide
inget_commits_info
andget_commit_info
This PR changes
get_commits_info
andget_commit_info
to usegitoxide
under the hood. It does not explicitly change any behaviour, although there possibly are subtle differences that I’m not aware of.This implementation doesn’t log an error when either
author
orcommitter
cannot be resolved usingmailmap
as the underlying implementation returnsOption<Signature>
instead ofResult<Signature>
. If you want, I can change that, though.I decided to duplicate the logic of
get_message
intogix_get_message
, using a prefix for the time both implementations are required.I did not attempt to re-organize any of the code. My plan is to convert more functions to
gitoxide
before making any changes in that direction.I followed the checklist:
make check
without errors