Fix - Default tech in Tasks Templates

[RomainLvr]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !37234
• Here is a brief description of what this PR does

In task templates, when the "By" parameter is left empty, selecting that template in the ticket task creation form should result in the "Technician" field being empty as well. However, the current behavior incorrectly assigns the logged-in user as the technician. This PR fixes the issue so that the "Technician" field correctly remains empty, respecting the task template configuration.

Rollback a part of this PR : #17360

[cconard96]

This doesn't seem logical to me. If I create a task template, I expect it to show as my task when used. Only in very specific circumstances could I see overriding the task author in a template as useful. Therefore, using the current user should be the default if not specified rather than having a task show as written by nobody.

[stonebuzz]

This doesn't seem logical to me. If I create a task template, I expect it to show as my task when used. Only in very specific circumstances could I see overriding the task author in a template as useful. Therefore, using the current user should be the default if not specified rather than having a task show as written by nobody.

The purpose of this Pull Request is to restore the default behavior of GLPI, which is: if no actor is specified in the template, GLPI defaults to the logged-in user.

The PR mentioned by Romain removed this default behavior. Now, if no actor is specified in the template, no actor is selected in the task, which has led to support requests.

I understand that leaving the template field empty should result in an empty task field. However, there is a need for the option to set the logged-in user as the default when selecting the template.

To address this, I propose adding a new option in the by field of the template: ["-1" => "Current logged-in user"]. This way, we would have all the following possibilities:

• Empty by field in the template -> Empty "by" field in the task.
• by field set to "Current logged-in user" -> Current logged-in user in the task.
• by field set to a specific user -> Specific user in the task.

[trasher]

[...]
To address this, I propose adding a new option in the by field of the template: ["-1" => "Current logged-in user"]. This way, we would have all the following possibilities:

* Empty `by` field in the template -> Empty "by" field in the task.

* `by` field set to "Current logged-in user" -> Current logged-in user in the task.

* `by` field set to a specific user -> Specific user in the task.

This looks like correct to me. @cconard96 are you OK with this proposal?

[RomainLvr]

The option has been added and the behavior works, but there's still a problem with the display of this new value in the list of task templates.

For example, the By field in the first template is Current logged-in user, but the value displayed is empty.

[cconard96]

The purpose of this Pull Request is to restore the default behavior of GLPI, which is: if no actor is specified in the template, GLPI defaults to the logged-in user.

That isn't what the PR description said though.

In task templates, when the "By" parameter is left empty, selecting that template in the ticket task creation form should result in the "Technician" field being empty as well. However, the current behavior incorrectly assigns the logged-in user as the technician.

That description makes it sound like not setting a technician in the template should result in the task not having a technician instead of the current behavior which has the task author as the current user by default.

To address this, I propose adding a new option in the by field of the template

I can't think of a legitimate reason for tasks to have no technician assigned or for the default, empty value for a template to result in a task with no technician assigned.

[Rom1-B]

Please add some tests (surprising that it hasn't already been requested — not naming anyone 😄).