Configure helpdesk home page illustration #19464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienClairembault
force-pushed
the
config-helpdesk-scenes
branch
from
81b0091 to
46d89d4
Compare
AdrienClairembault
force-pushed
the
config-helpdesk-scenes
branch
from
46d89d4 to
7c92cbc
Compare
cedric-anne
reviewed
Apr 16, 2025
templates/pages/admin/helpdesk_home_custom_scene_config.html.twig
Outdated
Show resolved
Hide resolved
templates/pages/admin/helpdesk_home_custom_scene_config.html.twig
Outdated
Show resolved
Hide resolved
Comment on lines
+90
to
+98
| {% do call('Dropdown::showFromArray', [ | ||
| side.field, | ||
| options, | ||
| { | ||
| value: side.config, | ||
| width: "100%", | ||
| aria_label: side.dropdown_label, | ||
| } | ||
| ]) %} |
There was a problem hiding this comment.
There is a dropdownArrayField macro.
There was a problem hiding this comment.
I don't want the full macro, I just need a dropdown.
|
|
||
| if ($value == self::SCENE_DEFAULT) { | ||
| // Reset default value (empty string) | ||
| $input[$field] = ""; |
There was a problem hiding this comment.
Maybe storing default in DB instead of an empty string would be easier to read.
There was a problem hiding this comment.
This is not ideal because the field is name "custom_scene_left/right".
An empty value make sense to mean there are no custom scene defined.
If you want to be extra precise, we need an extra field that store the behavior : default/custom/-2.
This would be clearer but come at the cost of adding 2 extra fields to a table that already have 124 columns.
I'm not against it, just let me know what you want.
Co-authored-by: Cédric Anne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Allow administrators to configure custom images for the helpdesk home page:
Screenshots