Fix actions skipped commit status indicator

[badhezi]

Addresses #34500

[silverwind]

Seems good, but I wonder whether the other two missing statuses from action model should also be represented in commit status. Currently "blocked" and "unknown" are missing:

gitea/models/actions/status.go

Lines 15 to 24 in 14bb8f7

	const (
	StatusUnknown Status = iota // 0, consistent with runnerv1.Result_RESULT_UNSPECIFIED
	StatusSuccess // 1, consistent with runnerv1.Result_RESULT_SUCCESS
	StatusFailure // 2, consistent with runnerv1.Result_RESULT_FAILURE
	StatusCancelled // 3, consistent with runnerv1.Result_RESULT_CANCELLED
	StatusSkipped // 4, consistent with runnerv1.Result_RESULT_SKIPPED
	StatusWaiting // 5, isn't a runnerv1.Result
	StatusRunning // 6, isn't a runnerv1.Result
	StatusBlocked // 7, isn't a runnerv1.Result
	)

[silverwind]

Change is LGMT but we should review the other two potential missing states later.

[ChristopherHX]

For consistency maybe add add

// IsSkipped represents if commit status state is skipped
func (css CommitStatusState) IsSkipped() bool {
	return css == CommitStatusSkipped
}

[ChristopherHX]

Are commit statuses correctly merged with this change?

In Pull Request Status / Merged Commit Status Icon

I looked at other locations of the other constants.

e.g. assign skipped value 5

The compare method returns false in both directions if not part of commitStatusPriorities e.g. making a stable sort impossible.