fix: return 201 Created for CreateVariable API responses #34517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change CreateVariable API response status from 204 No Content to 201 Created - Update related integration tests to expect 201 Created instead of 204 No Content Signed-off-by: Bo-Yi Wu <[email protected]>
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
- Change API response status for variable creation from 204 No Content to 201 Created - Update integration tests to expect 201 Created status after creating variables Signed-off-by: Bo-Yi Wu <[email protected]>
- Change response status code from 204 No Content to 201 Created when creating a variable Signed-off-by: Bo-Yi Wu <[email protected]>
|
swagger documentation need to be updated. |
lunny
added
the
pr/breaking
- Update variable creation responses to use repo-level terminology instead of org-level or generic descriptions - Replace 404 not found responses with 409 conflict responses when a variable name already exists - Remove redundant or outdated 204 response descriptions for variable creation endpoints Signed-off-by: Bo-Yi Wu <[email protected]>
|
Changing 2xx to 2xx and 4xx to 4xx is probably a low-impact change, but could you add a note regarding the 4xx change to OP message and some textual justifications? Also please follow template from https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#how-to-handle-breaking-prs. |
|
LGTM except #34517 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API SDK: https://gitea.com/gitea/go-sdk/pulls/713