Fix: Validator panics when 'nil' is used along with required if for slices and maps #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferent case to check length of array since arrays cannot be nil in go
… validation for arrays when used with required if
…nsive tests for all cases remain
|
@nodivbyzero kindly take a look and let me know if I need to change anything else |
nodivbyzero
approved these changes
Jun 19, 2025
|
@nodivbyzero, if everything looks good, can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Added support to check for 'nil' values in case of maps and slices when used with required if. (Previously only lengths were being checked as a result using nil with required if would lead to a panic since the program tried to convert 'nil' to an integer)
Created a separate case for arrays to only check lengths since arrays cannot be nil in go.
Check #1437 for more details.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers