feat(tools): evaluate\selector\screenshot #10
Conversation
zeoxisca
commented
Apr 2, 2025
zeoxisca
commented
- beautify tool key, use global const key to constraint tool name
- add createTab\evaluate\selector\screenshot handler functions
|
LGTM |
tools/common.go
Outdated
| ) | ||
| ) | ||
|
|
||
| type ToolHandler = func(rodCtx *types.Context) func(context.Context, mcp.CallToolRequest) (*mcp.CallToolResult, error) | ||
|
|
||
| var ( | ||
| CreateTabHandler = func(rodCtx *types.Context) func(context.Context, mcp.CallToolRequest) (*mcp.CallToolResult, error) { |
There was a problem hiding this comment.
CreateTableHandler seems to duplicate the Navigation function. So far, do you want to open multiple pages in a browser at the same time?
There was a problem hiding this comment.
multiple pages must be taken into account
There was a problem hiding this comment.
multiple pages must be taken into account
Of course, it in the plan. however, there are some problems with your implementation: we should think that mange the all pages, not replace old page with new page.
|
I suggest turning off this PR. You can add a new PR except for |
|
Done, createTab removed |
zeoxisca
changed the title
types/context.go
Outdated
| @@ -74,6 +75,7 @@ type Context struct { | |||
| config Config | |||
| browser *rod.Browser | |||
| page *rod.Page | |||
| element *rod.Element | |||
There was a problem hiding this comment.
Do you add this what do you want to do? I didn't see where it were used
tools/common.go
Outdated
| if element == nil || element.Object == nil { | ||
| return nil, errors.New(fmt.Sprintf("Failed to find element %s: %s", selector, err.Error())) | ||
| } |
There was a problem hiding this comment.
here has some problems?
tools/common.go
Outdated
| if element == nil || element.Object == nil { | ||
| return nil, errors.New(fmt.Sprintf("Failed to find element: %s", selector)) | ||
| } |
There was a problem hiding this comment.
the same as fill handler
