impl Hash for Gd<T> per instance ID #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-504 |
Bromeon
reviewed
Nov 27, 2023
godot-core/src/obj/gd.rs
Outdated
| @@ -654,6 +654,16 @@ impl<T: GodotClass> Debug for Gd<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: GodotClass> std::hash::Hash for Gd<T> { | |||
| /// ⚠️ Hashes this object based on it's instance ID. | |||
jrockett6
force-pushed
the
hash_for_gd
branch
from
e2805be to
08cfadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to
HashGd's a ton in my development, but end up working around not having this by hashingGStringand callingget_node(), so this would be a nice convenience to have. Also others have inquiredIf this isn't desired though feel to ignore.
Minor progress on #297