Update pck section of embedding Godot to Android #10862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated "Create the Godot Project" section of the tutorial page for embedding Godot to an existing Android project [1]. I specified that the pck file needs to be prefixed with "res://" and written a Kotlin code example. [1] https://docs.godotengine.org/en/stable/tutorials/platform/android/android_library.html#create-the-godot-project
skyace65
added
enhancement
area:manual
m4gr3d
reviewed
Apr 15, 2025
There was a problem hiding this comment.
@kkartal-infodif This PR has partial overlap with #10758.
You can either update the changes to the ones not covered by the other PR, or comment on the other PR so that they can include your changes.
| @@ -177,7 +177,13 @@ Below we break-down the steps used to create the GLTF Viewer app. | |||
|
|
|||
| Note that it's also possible to create the Godot project in a separate directory and export it as a `PCK or ZIP file <https://docs.godotengine.org/en/stable/tutorials/export/exporting_projects.html#pck-versus-zip-pack-file-formats>`_ | |||
| to the Android app's ``assets`` directory. | |||
| Using this approach requires passing the ``--main-pack <pck_or_zip_filepath_relative_to_assets_dir>`` argument to the hosted Godot Engine instance using `GodotHost#getCommandLine() <https://github.com/godotengine/godot/blob/6916349697a4339216469e9bf5899b983d78db07/platform/android/java/lib/src/org/godotengine/godot/GodotHost.java#L45>`_. | |||
| Using this approach requires passing the ``--main-pack res://<pck_or_zip_filepath_relative_to_assets_dir>`` argument to the hosted Godot Engine instance using `GodotHost#getCommandLine() <https://github.com/godotengine/godot/blob/6916349697a4339216469e9bf5899b983d78db07/platform/android/java/lib/src/org/godotengine/godot/GodotHost.java#L45>`_. | |||
There was a problem hiding this comment.
I don't think we need to specify res:// in --main-pack res://<pck_or_zip_filepath_relative_to_assets_dir>. Example should be enough.
|
#10758 already covers the changes made in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated "Create the Godot Project" section of the tutorial page for embedding Godot to an existing Android project [1]. I specified that the pck file needs to be prefixed with "res://" and written a Kotlin code example.
[1] https://docs.godotengine.org/en/stable/tutorials/platform/android/android_library.html#create-the-godot-project