-
Notifications
You must be signed in to change notification settings - Fork 18.1k
slices: tolerate Chunk([]string{}, 0) without raising panic for n<1 #73880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: ed83029) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/678637. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/678637. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/678637. |
Message from Ingo Oeser: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/678637. |
Message from Marco Mariani: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/678637. |
Message from Marco Mariani: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/678637. |
I noticed many of my uses of Chunk have an optional value for n,
and it's ok to not split the data otherwise.
Unless the slice is empty, because if n is optional (0) the stdlib
implementation panics, so while migrating from my own implementation I
have to resort to an if/else or a contraption
which makes the code hard to follow and is prone to errors.
Tis PR keeps the panic for n<0 in all cases.