travis: add testing #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbinet
previously approved these changes
Jul 24, 2018
.travis/check-generate.sh
Outdated
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| go generate gonum.org/v1/gonum/blas | |||
| - if [[ $TRAVIS_SECURE_ENV_VARS = "true" ]]; then bash ./.travis/test-coverage.sh; fi | ||
| - ${TRAVIS_BUILD_DIR}/.travis/check-imports.sh | ||
| # This is run last since it alters the tree. | ||
| - ${TRAVIS_BUILD_DIR}/.travis/check-generate.sh |
There was a problem hiding this comment.
I'll leave this one here though.
| @@ -0,0 +1,34 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this is actually something that could be rewritten in Go and put as a standalone command in gonum/tools :)
(this script is using many UNIX commands...)
There was a problem hiding this comment.
File an issue for that? It can live here and be used Gonum-wide.
.travis/test-coverage.sh
Outdated
| echo "mode: set" > $ACC_OUT | ||
|
|
||
| # Run test coverage on all directories containing go files except testlapack and testblas. | ||
| find . -type d -not -path '*testlapack*' -and -not -path '*testblas*' | while read d; do testCover $d || exit; done |
There was a problem hiding this comment.
do we need this, here in this repo?
There was a problem hiding this comment.
The -not -path expressions can go away.
|
PTAL |
sbinet
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.