Add tolerance to not_done condition of time step calculator.
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_744753327
branch
8 times, most recently
from
93dc35f to
8be8933
Compare
This avoids running an apparent extra step for the final step when we are a very small amount below exact_t_final, the rounding of logged values makes it appear like t_final is reached. PiperOrigin-RevId: 744871073
copybara-service
bot
force-pushed
the
test_744753327
branch
from
8be8933 to
bb95d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tolerance to
not_donecondition of time step calculator.This avoids running an apparent extra step for the final step when we are a very small amount below exact_t_final, the rounding of logged values makes it appear like t_final is reached.