Add support for global constants to constant folder #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
TristonianJones
previously approved these changes
May 19, 2025
zeitgeist87
force-pushed
the
add_identifier_support_for_constant_folding
branch
3 times, most recently
from
85b2629 to
cc30e3b
Compare
Global constants like enums are represented in the AST as identifiers. These identifiers can be looked up in the AST reference map. If there is an entry in the reference map, we can try to fold it as a constant and to turn it into a literal. This reduces the size of the AST and unlocks more optimization opportunities.
zeitgeist87
force-pushed
the
add_identifier_support_for_constant_folding
branch
from
cc30e3b to
fd56eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global constants like enums are represented in the AST as identifiers. These identifiers can be looked up in the AST reference map. If the entry in the reference map has a value associated with it, we can treat it as a constant and attempt to turn it into a literal.
This reduces the size of the AST and unlocks more optimization opportunities.