-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document translation workflow #2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9fde70e
to
50828d1
Compare
- Publish the entire `book/html/` directory to | ||
https://google.github.io/comprehensive-rust/. | ||
|
||
### `build.sh` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention when this script is being called (publish.yml and build.yml) and that both times there are artifacts that can be inspected if necessary.
default to make it easier for people to run `mdbook build` without having to | ||
configure LaTeX. | ||
|
||
#### Restoring Translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include that the English translation does not involve the git restore step and always builds from HEAD
This PR is relevant for #2541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall but I would like to have the two comments addressed before merging this
This is a first draft of explaining the documentation workflow. Let's discuss this a bit before merging.