-
Notifications
You must be signed in to change notification settings - Fork 95
Disable fuzztest subprocess library on Apple tvOS #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our Chromium fork for Apple tvOS, we build against the tvOS SDK.
I think this PR makes sense even without mentioning Chromium, as these changes help anyone trying to build and use fuzz tests on tvOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still reword the first paragraph of the PR message. Saying that tvOS builds use the tvOS SDK is redundant, so something like this should suffice:
In our Apple tvOS build environment, we compile FuzzTest against the
tvOS SDK.
On tvOS, creating child processes is forbidden at an API level, so the
posix_spawn_*
functions used by FuzzTest in the subprocess code cause build errors.
46ca685
to
edf62eb
Compare
Looks fine to me! @lszekeres could you take a look at this PR? The CMake codelab check seems to be failing because the code assumes that the PR branch was pushed to the google/fuzztest repository rather than a fork. |
We need to use the PR repo, not the upstream in the codelab test. Context: #1711 (comment) PiperOrigin-RevId: 762676963
We need to use the PR repo, not the upstream in the codelab test. Context: #1711 (comment) PiperOrigin-RevId: 762676963
We need to use the PR repo, not the upstream in the codelab test. Context: #1711 (comment) PiperOrigin-RevId: 763113538
@lszekeres Is this failure caused by an issue in the internal tooling or framework? Also, is it related to this(07d3d31) patch that's supposed to fix the CMake build failure Thanks! |
@abhijeetk you can try amending the commit to change the hash and force-pushing your branch to trigger the CI again, that commit should've fixed things. |
On tvOS, creating child processes is forbidden at an API level, so the posix_spawn_* functions used by FuzzTest in the subprocess code cause build errors. This change disables the subprocess library on Apple tvOS to avoid calling unsupported functions. This isssue is similar to b222049 Co-Authored-By: [email protected]
edf62eb
to
6d0b498
Compare
Hi @lszekeres, I think we’re very close. The GCC build appears to be failing, but I couldn’t find a specific error message in the logs. Do you have any insight into what might be causing it? |
Thanks everyone for review. |
Thanks for the PR! |
On tvOS, creating child processes is forbidden at an API level, so the
posix_spawn_* functions used by FuzzTest in the subprocess code cause
build errors.
This change disables the subprocess library on Apple tvOS to avoid
calling unsupported functions.
This isssue is similar to b222049
Co-Authored-By: [email protected]