Skip to content

Fix compatibility with setuptools 72 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

ilpianista
Copy link
Contributor

Due to test command removal in setuptools, installation fails with version 72:

# pip wheel --no-cache-dir --use-pep517 "gojsonnet (==0.20.0)"
Collecting gojsonnet==0.20.0
  Downloading gojsonnet-0.20.0.tar.gz (7.4 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.4/7.4 MB 15.0 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      Traceback (most recent call last):
        File "/usr/local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/usr/local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/usr/local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-i9xslfbh/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
        File "/tmp/pip-build-env-i9xslfbh/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-i9xslfbh/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 497, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-i9xslfbh/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 313, in run_setup
          exec(code, locals())
        File "<string>", line 19, in <module>
      ModuleNotFoundError: No module named 'setuptools.command.test'

pytest advises to not integrate with setuptools anymore, thus I've dropped that part.

@ilpianista
Copy link
Contributor Author

@sparkprime may you have a look at this please? Thanks

@coveralls
Copy link

Coverage Status

coverage: 55.574%. remained the same
when pulling fe1d35d on ilpianista:bugfix/setuptools-72
into 7a714b9 on google:master.

@johnbartholomew johnbartholomew merged commit fe1d35d into google:master Mar 12, 2025
6 checks passed
@johnbartholomew
Copy link
Collaborator

Thanks for the contribution! I have rebased it onto master and merged it.

@ilpianista ilpianista deleted the bugfix/setuptools-72 branch March 13, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants