Skip to content

Make StrMatcher generic over the times matcher #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bjacotg
Copy link
Collaborator

@bjacotg bjacotg commented Feb 9, 2024

Make StrMatcher generic over the TimesMatcher (and use a place holder to mark it as no matcher provided).

This allows to avoid the usage of dyn Matcher which will not be supported after the fix of #353 (which is likely to make Matcher not object safe).

@bjacotg
Copy link
Collaborator Author

bjacotg commented May 3, 2024

With #349, this is now unnecessary.

@bjacotg bjacotg closed this May 3, 2024
@bjacotg bjacotg deleted the str_matcher_without_dyn branch May 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant