Skip to content

Monkey-patch os.path to support gs:// URIs #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions learned_optimization/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@
# limitations under the License.

"""learned_optimizer module."""

from .py_utils import patch_os_path_get_sep

_OLD_OS_PATH_GET_SEP = patch_os_path_get_sep()
24 changes: 24 additions & 0 deletions learned_optimization/py_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# limitations under the License.

"""Common python utilities."""
import os
from concurrent import futures
from typing import Any, Callable, Sequence
import tqdm
Expand All @@ -26,3 +27,26 @@ def threaded_tqdm_map(threads: int, func: Callable[[Any], Any],
for l in tqdm.tqdm(data):
future_list.append(executor.submit(func, l))
return [x.result() for x in tqdm.tqdm(future_list)]


def patch_os_path_get_sep():
old_get_sep = os.path._get_sep

def new_get_sep(path):
"""Return the OS separator for the given path.

If `path` starts with "gs://", "/" is used as the separator.
"""
if isinstance(path, bytes):
gs_prefix = b'gs://'
sep = b'/'
else:
gs_prefix = 'gs://'
sep = '/'

if not path.startswith(gs_prefix):
sep = old_get_sep(path)
return sep

os.path._get_sep = new_get_sep
return old_get_sep