-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update ast for supporting generics #385
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@toddtreece Could you help me review this PR 🙇 |
@zombiezen PTAL |
|
||
import "github.com/google/wire" | ||
|
||
func InitializeFooStore() FooStorer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. We should add to this test to ensure Wire can also generate injector functions with generic-typed parameters and return values correctly. If all that works, then LGTM.
This PR is a follow-up to reverted PR #360.