-
Notifications
You must be signed in to change notification settings - Fork 132
docs: Update SpannerSample.java to align with best practices #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Encapsulates both statements in a try-with-resources statement
I don't work with github very often, so if I can get a hand in getting the tests passed, I would greatly appreciate it. |
@adhiggs please update your commit message to follow the convention. https://www.conventionalcommits.org/en/v1.0.0/ |
@sakthivelmanii - I think I got it? PTAL. |
@sakthivelmanii - Could you take a look at this request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the code issue
samples/snippets/src/main/java/com/example/spanner/SpannerSample.java
Outdated
Show resolved
Hide resolved
Please fix the checkstyle issues.
https://github.com/googleapis/java-spanner/actions/runs/15027603684/job/42257173380?pr=3625 |
docs: update SpannerSample.java to align with best practices
Encapsulates both ResultSet statements in try-with-resources statements to align with best practices.
Fixes #3623 ☕️