chore: introduce .kokoro templates for GraalVM jobs #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
added a commit
to googleapis/java-storage
that referenced
this pull request
Apr 10, 2025
See the PR in sdk-platform-java for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-bigquerystorage
that referenced
this pull request
Apr 11, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-bigtable
that referenced
this pull request
Apr 11, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-datastore
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-firestore
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-logging
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-pubsub
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-pubsublite
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
diegomarquezp
added a commit
to googleapis/java-spanner
that referenced
this pull request
Apr 14, 2025
See [sdk-platform-java#3737](googleapis/sdk-platform-java#3737) for more context. TL;DR: we are introducing an additional Kokoro job to run native tests against GraalVM for JDK 17.0.9
blakeli0
reviewed
Apr 14, 2025
There was a problem hiding this comment.
what exactly does graalvm-a/b/c mean?
There was a problem hiding this comment.
The full context is in a new support policy for GraalVM images. TLDR is that we want to keep a few placeholder jobs for frequently changing GraalVM images (e.g. we will now suport GraalVM for JDK 17 (C), 21 (A) and 23 (B)). In this way, we can avoid renaming the jobs based on the JDK versions these images run on.
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/build.sh
Outdated
Show resolved
Hide resolved
suztomo
approved these changes
Apr 14, 2025
| @@ -49,8 +49,9 @@ branchProtectionRules: | |||
| - "Kokoro - Test: Integration" | |||
| - "cla/google" | |||
| - "OwlBot Post Processor" | |||
| - "Kokoro - Test: Java GraalVM Native Image" | |||
| - "Kokoro - Test: Java 17 GraalVM Native Image" | |||
There was a problem hiding this comment.
This is unclear what is tested.
mpeddada1
approved these changes
Apr 14, 2025
blakeli0
reviewed
Apr 14, 2025
hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/build.sh
Outdated
Show resolved
Hide resolved
diegomarquezp
added
the
automerge
blakeli0
approved these changes
Apr 14, 2025
|
|
diegomarquezp
commented
Apr 15, 2025
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.45.1" |
There was a problem hiding this comment.
Let's change this according to the file name
lqiu96
pushed a commit
that referenced
this pull request
Apr 17, 2025
Context: [we will introduce a new GraalVM job](https://docs.google.com/document/d/1bOeGtVFLsq5ts71If5pFXCvHIeNpbtBRvF6XQfavLZs/edit?tab=t.dcjxhf429j6t#bookmark=id.3s7d4dj247hr) and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated). Demo PRs * googleapis/java-bigtable#2558 * googleapis/java-bigquerystorage#2937 * googleapis/java-storage#3029 * googleapis/java-datastore#1816 * There are manual changes in `build.sh`. We will add this file to the [ignored files in owlbot.py](https://github.com/googleapis/java-datastore/blob/8ceb62b5182e30b4f771d6c1b586a22fb084c9ac/owlbot.py#L48-L57) and will raise an issue to move this logic elsewhere (if feasible). * googleapis/java-firestore#2074 * googleapis/java-logging#1789 * googleapis/java-pubsub#2389 * googleapis/java-pubsublite#1839 * googleapis/java-spanner#3821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: we will introduce a new GraalVM job and will leverage the hermetic build templates to propagate this change to some of the repositories. Each PR will be followed with ad-hoc changes such as sync-repo-settings (the cannot be templated).
Demo PRs
build.sh. We will add this file to the ignored files in owlbot.py and will raise an issue to move this logic elsewhere (if feasible).