chore: replace mcp-go with nanobot #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
commented
Jun 12, 2025
| @@ -49,7 +49,7 @@ serve-docs: | |||
|
|
|||
| # This will initialize the node_modules needed to run the docs dev server. Run this before running serve-docs | |||
| init-docs: | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster yarn install | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster npm install | |||
There was a problem hiding this comment.
Is this OK? It looked like we are using npm everywhere else.
|
Looks like there's an issue here. Moving to draft while I figure it out. |
g-linville
previously approved these changes
Jun 12, 2025
| @@ -49,7 +49,7 @@ serve-docs: | |||
|
|
|||
| # This will initialize the node_modules needed to run the docs dev server. Run this before running serve-docs | |||
| init-docs: | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster yarn install | |||
| docker run --rm --workdir=/docs -v $${PWD}/docs:/docs node:18-buster npm install | |||
thedadams
force-pushed
the
replace-mcp-go-with-nanobot
branch
from
be9260e to
cd80db5
Compare
g-linville
previously approved these changes
Jun 12, 2025
| if err := daemon.SysDaemon(); err != nil { | ||
| log.Debugf("failed running daemon: %v", err) | ||
| if os.Args[1] == "_exec" { | ||
| if err := supervise.Daemon(); err != nil { |
There was a problem hiding this comment.
should we print the error?
StrongMonkey
previously approved these changes
Jun 12, 2025
njhale
previously approved these changes
Jun 12, 2025
Comment on lines
+17
to
32
| if os.Args[1] == "sys.daemon" { | ||
| if os.Getenv("GPTSCRIPT_DEBUG") == "true" { | ||
| mvl.SetDebug() | ||
| } | ||
| if err := daemon.SysDaemon(); err != nil { | ||
| log.Debugf("failed running daemon: %v", err) | ||
| } | ||
| os.Exit(0) | ||
| } | ||
| if err := daemon.SysDaemon(); err != nil { | ||
| log.Debugf("failed running daemon: %v", err) | ||
| if os.Args[1] == "_exec" { | ||
| if err := supervise.Daemon(); err != nil { | ||
| _, _ = fmt.Fprintf(os.Stderr, "failed running _exec: %v\n", err) | ||
| os.Exit(1) | ||
| } | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
nano-nit: could use a switch statement here.
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
replace-mcp-go-with-nanobot
branch
from
bcc5b87 to
afb3675
Compare
|
The final pushes were removing the replace directive and rebasing. So, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.