feat(graindoc): Add bind information to errors #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
phated,
marcusroberts,
ospencer,
alex-snezhko and
peblair
as code owners
|
I think it'd be better to just provide the location. We do lex the comments, so theoretically the information is there. |
That would probably be better, I didn't know how to properly hook into our error handler with the nice locations from the compiler. The location information itself should be easy to get beyond that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds the bind that is causing the issue to help with debugging. I think it would be beneficial if we had the full error location as well but I don't quite understand how our error_reporting works enough to make that change yet.
Work towards: #1983