Skip to content

wip: horizon migration fix support #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

suchapalaver
Copy link
Collaborator

@suchapalaver suchapalaver commented Jun 20, 2025

Summary

This PR creates a branch that builds indexer-service and indexer-tap-agent (aka tap-agent) with Horizon support, targeting usage with the suchapalaver/test/horizon branch of local-network. This enables testing and development for Horizon on both local and testnet environments.

How to Test

After checking out this branch of indexer-rs, run:

just setup

This uses the justfile to invoke setup-test-network.sh, which pulls in the Semiotic fork of local-network at suchapalaver/test/horizon.

Tip: If you've previously run the test network, you may want to fully clean up with:

just down
docker system prune -a
docker volume prune

before setting it up again with just setup.

Next Steps

We're now working on updating local-network tests to verify that v2 receipts behave as expected—ideally matching the behavior of v1 receipts.

  • fix just test-local tests for horizon/v2
  • ...

Signed off by Joseph Livesey [email protected]

@suchapalaver suchapalaver changed the base branch from main to tmigone/horizon-migration-fix June 20, 2025 23:03
@suchapalaver suchapalaver marked this pull request as ready for review June 20, 2025 23:04
@suchapalaver suchapalaver marked this pull request as draft June 20, 2025 23:04
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch 5 times, most recently from 1ad2da9 to 2268792 Compare June 23, 2025 21:15
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from 2268792 to e837c9b Compare June 23, 2025 21:19
@suchapalaver suchapalaver changed the base branch from tmigone/horizon-migration-fix to main June 23, 2025 21:20
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch 3 times, most recently from 4903bb3 to f85d093 Compare June 23, 2025 21:33
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from 8161ba1 to aa47f97 Compare June 23, 2025 22:05
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from e9db5a8 to cf76df4 Compare June 24, 2025 16:07
tempfile = "3.8.0"
test-log = { version = "0.2.12", default-features = false }
test-with = "0.14.6"
thegraph-core = { version = "0.15.0", features = [
thegraph-core = { version = "0.15.1", features = [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us the CollectionId type.

Copy link
Contributor

github-actions bot commented Jun 24, 2025

Pull Request Test Coverage Report for Build 15931469627

Details

  • 232 of 980 (23.67%) changed or added relevant lines in 38 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-2.8%) to 69.57%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/lib.rs 2 3 66.67%
crates/profiler/src/lib.rs 0 1 0.0%
crates/service/src/metrics.rs 0 1 0.0%
crates/tap-agent/src/tap/context/checks/allocation_id.rs 5 6 83.33%
crates/tap-agent/src/tap/context/escrow.rs 0 1 0.0%
crates/dips/src/ipfs.rs 0 2 0.0%
crates/indexer-receipt/src/lib.rs 8 10 80.0%
crates/query/src/lib.rs 1 3 33.33%
crates/service/src/tap/checks/allocation_eligible.rs 2 4 50.0%
crates/tap-agent/src/metrics.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_account.rs 1 73.03%
crates/tap-agent/src/tap/context/rav.rs 1 86.89%
crates/service/src/service.rs 2 0.0%
crates/watcher/src/lib.rs 4 92.71%
Totals Coverage Status
Change from base Build 15835007232: -2.8%
Covered Lines: 8898
Relevant Lines: 12790

💛 - Coveralls

@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch 5 times, most recently from da2bdfd to 2c1dd9b Compare June 26, 2025 01:44
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from 2c1dd9b to 151383b Compare June 26, 2025 13:15
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch 3 times, most recently from 81f6a2c to c5f3b67 Compare June 26, 2025 21:30
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from c5f3b67 to b9f157f Compare June 26, 2025 21:46
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from fc88f5e to ab34926 Compare June 27, 2025 02:44
Signed-off-by: Joseph Livesey <[email protected]>
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from ee0931f to e84cd9f Compare June 27, 2025 16:08
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from 1705f25 to 9dc93b5 Compare June 27, 2025 20:40
@suchapalaver suchapalaver force-pushed the suchapalaver/horizon-migration-fix-support branch from 9dc93b5 to 2fe81a3 Compare June 27, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants