Skip to content

bubbletea: Adds code comments. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

bubbletea: Adds code comments. #40

merged 1 commit into from
Apr 1, 2025

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Apr 1, 2025

Details

  • Part of: TODOS #31.
  • bubbletea: adds code comments.

Test Plan

✔️ Tested that the CLI works as expected:

$ ./bin/start.sh 
Specification: https://github.com/graphql/graphql-spec/releases/tag/October2021
(•) Implementation: https://github.com/graphql-go/graphql/releases/tag/v0.8.1


(press q to quit)
2025/04/01 14:07:26 failed to extract: failed extract implementation: failed to execute: Cannot query field "deprecationReason" on type "__InputValue".: Cannot query field "isDeprecated" on type "__InputValue".: Unknown argument "includeDeprecated" on field "inputFields" of type "__Type".: Unknown argument "includeDeprecated" on field "args" of type "__Field".: Cannot query field "isOneOf" on type "__Type".: Cannot query field "specifiedByURL" on type "__Type".: Unknown argument "includeDeprecated" on field "args" of type "__Directive".: Cannot query field "isRepeatable" on type "__Directive".: Cannot query field "description" on type "__Schema". Did you mean "subscriptionType"?
exit status 1

Copy link

mentatbot bot commented Apr 1, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

Copy link

@mentatbot mentatbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR and it looks good! Adding code comments improves the maintainability and readability of the codebase.

The documentation is well-written, accurately describes the functions and structs, and follows a consistent style. This is a straightforward improvement that doesn't affect functionality but makes the code more accessible for future developers.

Approving this change. Good work!

@chris-ramon
Copy link
Member Author

LGTM 👍 🚢

@chris-ramon chris-ramon changed the title 31-code-comments bubbletea: Adds code comments. Apr 1, 2025
@chris-ramon chris-ramon merged commit 78d7c70 into main Apr 1, 2025
@chris-ramon chris-ramon deleted the 31-code-comments branch April 1, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant