Skip to content

Switch to indexmap 1.0 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2018
Merged

Switch to indexmap 1.0 #159

merged 1 commit into from
Apr 22, 2018

Conversation

LegNeato
Copy link
Member

ordermap changed names to indexmap and released a stable 1.0.

`ordermap` changed names to `indexmap` and released a stable 1.0.
@sagiegurari
Copy link
Contributor

looks like cargo nightly version is broken

@sagiegurari
Copy link
Contributor

open issue to cargo rust-lang/cargo#5212

@theduke
Copy link
Member

theduke commented Mar 21, 2018

I'll re-trigger the build tomorrow and then merge.

@sagiegurari
Copy link
Contributor

builds won't pass on nightly until both rustc and cargo are fixed.
you could use nightly of February or make allow failures in build for nightly for builds to pass.

@theduke
Copy link
Member

theduke commented Mar 21, 2018

The PR has been merged, no?
If so so let's hope that tomorrows nightly is fixed.

@sagiegurari
Copy link
Contributor

unfortunately, cargo fix keeps failing in their build and as for rustc, they currently don't know the reason the incremental builds keep failing.
you could disable the incremental builds via env var to workaround that issue, but the cargo issue is still not solved.

@LegNeato
Copy link
Member Author

There's no rush on this, we can sit back until nightly is fixed.

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #159 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #159      +/-   ##
=========================================
+ Coverage   90.99%     91%   +<.01%     
=========================================
  Files          95      95              
  Lines       16341   16381      +40     
=========================================
+ Hits        14870   14908      +38     
- Misses       1471    1473       +2
Impacted Files Coverage Δ
juniper/src/executor_tests/variables.rs 95.35% <ø> (ø) ⬆️
juniper/src/macros/tests/object.rs 84.54% <ø> (ø) ⬆️
juniper/src/macros/tests/scalar.rs 70% <ø> (ø) ⬆️
juniper/src/executor_tests/enums.rs 97.8% <ø> (ø) ⬆️
juniper/src/integrations/serde.rs 20.9% <ø> (ø) ⬆️
juniper/src/lib.rs 84.61% <ø> (ø) ⬆️
juniper/src/macros/tests/union.rs 91.4% <ø> (ø) ⬆️
juniper/src/macros/tests/field.rs 96.03% <ø> (ø) ⬆️
juniper/src/executor_tests/introspection/enums.rs 95.47% <ø> (ø) ⬆️
juniper/src/executor_tests/directives.rs 99.38% <ø> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d8a3d...f136265. Read the comment docs.

@theduke
Copy link
Member

theduke commented Apr 22, 2018

@LegNeato thanks again!

I don't want to delay this any further so I'll merge right now, but can you do another PR updating the changelog?

@theduke theduke merged commit 218654e into graphql-rust:master Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants