Fix Issue #132 -- Make let Lazily Evaluated
#133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
============================================
+ Coverage 99.45% 99.47% +0.01%
- Complexity 349 358 +9
============================================
Files 43 44 +1
Lines 739 763 +24
Branches 22 23 +1
============================================
+ Hits 735 759 +24
Partials 4 4
|
The previous implementation would cause all `let` blocks to be evaluated at the start of the test rather than on an as-needed basis, which is inconsistent with the behavior developers who are used to RSpec would expect. Now, `let` only evaluates its block when the test first needs a value, allowing the `let` block to depend on state that is being setup by other blocks (`beforeEach`, other `let` blocks, etc).
GuyPaddock
force-pushed
the
feature/issue-132--let-should-be-lazy
branch
3 times, most recently
from
af9e80e to
24276b1
Compare
The previous implementation is closer to `let!` from RSpec. As such, it's still useful for cases in which a developer needs values to be available in the `beforeEach` block.
GuyPaddock
force-pushed
the
feature/issue-132--let-should-be-lazy
branch
from
24276b1 to
3f73979
Compare
|
Thanks for the contribution @GuyPaddock. This looks great, |
GuyPaddock
pushed a commit
to GuyPaddock/spectrum
that referenced
this pull request
Mar 24, 2018
Catches some documentation that wasn't updated in greghaskins#133.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would cause all
letblocks to be evaluated at the start of the test rather than on an as-needed basis, which is inconsistent with the behavior developers who are used to RSpec would expect. Now,letonly evaluates its block when the test first needs a value, allowing theletblock to depend on state that is being setup by other blocks (beforeEach, otherletblocks, etc).Despite this, there was value in preserving the old implementation as Spectrum's equivalent to
let!from RSpec. As such, I've moved that implementation over to a new DSL helper calledeagerLet. One use case where this is useful is defining values that can be used in abeforeEachblock.Closes #132.