Skip to content

Add ERC20TransferEvent and ERC721TransferEvent models #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lizard-boy
Copy link

What changed? Why?

  • Add ERC20TransferEvent and ERC721TransferEvent models for webhook event parsing
  • Minor comment update on event filter

Qualified Impact

@lizard-boy
Copy link
Author

@greptileai

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces new interfaces for ERC20 and ERC721 transfer events in the Coinbase SDK for Node.js, enhancing webhook event parsing capabilities. Key changes include:

  • Added ERC20TransferEvent interface for ERC-20 token transfers
  • Added ERC721TransferEvent interface for ERC-721 token transfers
  • Both interfaces include detailed blockchain event information (e.g., block details, transaction details, addresses involved)
  • Updated WebhookEventFilter interface with improved property descriptions

These additions will likely require updates to the Webhook class in src/coinbase/webhook.ts to properly handle and parse these new event types when received through webhooks.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants