Skip to content

xdsclient: delay resource cache deletion to handle immediate re-subscription of same resource #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented May 29, 2025

Fixes: #8125

RELEASE NOTES:

  • xdsclient: fixed an edge case race causing "resource doesn not exist" when rapidly subscribing and unsubscribing the same resource.

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 67.08861% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.26%. Comparing base (ec4810c) to head (a06eb28).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
xds/internal/clients/xdsclient/authority.go 44.11% 13 Missing and 6 partials ⚠️
xds/internal/clients/xdsclient/channel.go 78.12% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8369      +/-   ##
==========================================
+ Coverage   82.22%   82.26%   +0.03%     
==========================================
  Files         419      419              
  Lines       42047    42124      +77     
==========================================
+ Hits        34574    34652      +78     
- Misses       6003     6011       +8     
+ Partials     1470     1461       -9     
Files with missing lines Coverage Δ
xds/internal/clients/xdsclient/ads_stream.go 81.22% <100.00%> (+0.99%) ⬆️
xds/internal/clients/xdsclient/xdsclient.go 81.14% <100.00%> (+2.17%) ⬆️
xds/internal/clients/xdsclient/channel.go 78.37% <78.12%> (+1.25%) ⬆️
xds/internal/clients/xdsclient/authority.go 69.57% <44.11%> (-1.65%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@purnesh42H purnesh42H force-pushed the fix-xdsclient-resource-sub-unsub-race branch 2 times, most recently from 98808fe to d361cc6 Compare June 2, 2025 13:02
@purnesh42H purnesh42H force-pushed the fix-xdsclient-resource-sub-unsub-race branch from d361cc6 to e70fea2 Compare June 2, 2025 13:25
@dfawley
Copy link
Member

dfawley commented Jun 2, 2025

cc @danielzhaotongliu

@purnesh42H purnesh42H force-pushed the fix-xdsclient-resource-sub-unsub-race branch from 99d6a11 to 2e6ba1b Compare June 3, 2025 15:12
@purnesh42H purnesh42H requested review from easwars and dfawley June 3, 2025 15:14
@purnesh42H purnesh42H added Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug and removed Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Jun 3, 2025
@purnesh42H purnesh42H added this to the 1.74 Release milestone Jun 3, 2025
@dfawley dfawley removed their assignment Jun 3, 2025
@dfawley dfawley removed their request for review June 3, 2025 15:50
@purnesh42H purnesh42H force-pushed the fix-xdsclient-resource-sub-unsub-race branch from 2e6ba1b to a06eb28 Compare June 4, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xdsclient: race around resource subscriptions and unsubscsriptions
3 participants