Skip to content

xds: cancelled=true on watch close in XdsDepManager #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jun 8, 2025

1fd29bc replaced cancelWatcher() with watcher.close(). But setting cancelled was missing. Because the config update checks for shutdown, the cancelled flag no longer avoids exceptions. But it seems best to continue avoiding any processing after close to avoid surprises.

1fd29bc replaced cancelWatcher() with watcher.close(). But setting
cancelled was missing. Because the config update checks for shutdown,
the cancelled flag no longer avoids exceptions. But it seems best to
continue avoiding any processing after close to avoid surprises.
@ejona86 ejona86 requested a review from kannanjgithub June 8, 2025 20:35
@ejona86 ejona86 merged commit 4ee662f into grpc:master Jun 9, 2025
16 checks passed
@ejona86 ejona86 deleted the xdsdepman-cancel branch June 9, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants