This repository was archived by the owner on Jun 8, 2021. It is now read-only.
value::GetError: add a constructor and make fields public #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures on I'm on it, and will submit a separate PR. |
|
I'll rebase once #519 is merged |
The constructor allows instantiating the error outside of the module, e.g. for use in an `assert_eq!`. People might want to access the public fields when handling the error. Besides, if the error was implemented using an `enum`, fields would be public.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor allows instantiating the error outside of the module, e.g. for use in an
assert_eq!.People might want to access the public fields when handling the error. Besides, if the error was implemented using an
enum, the fields would be public.Fixes #515