Regenerate with gtk 3.99.3 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bilelmoussaoui merged 3 commits into master from bilelmoussaoui/update

Nov 5, 2020

Member

bilelmoussaoui commented Nov 4, 2020

Depends on #35

bilelmoussaoui force-pushed the bilelmoussaoui/update branch 2 times, most recently from ce5014c to ee8df7f Compare

November 5, 2020 01:20

Member

sdroege commented Nov 5, 2020

You seem to have forgotten to create the gir-files PR :)

sdroege reviewed

View reviewed changes

gdk4/src/auto/toplevel.rs Outdated Show resolved Hide resolved

sdroege reviewed

View reviewed changes

gtk4/src/auto/functions.rs Outdated Show resolved Hide resolved

sdroege reviewed

View reviewed changes

gtk4/src/auto/gesture.rs Show resolved Hide resolved

sdroege reviewed

View reviewed changes

gtk4/src/auto/tree_store.rs Show resolved Hide resolved

sdroege reviewed

View reviewed changes

Member

sdroege left a comment

Looks generally good to me apart from those comments.

bilelmoussaoui force-pushed the bilelmoussaoui/update branch from ee8df7f to fb67306 Compare

November 5, 2020 09:17

Member Author

bilelmoussaoui commented Nov 5, 2020

You seem to have forgotten to create the gir-files PR :)

This was handled by Chris few days ago already :)

bilelmoussaoui added 2 commits

November 5, 2020 10:34


          Regenerate with gtk 3.99.3

fc92521

Fixes #29


          gtk3.99.3: generate missing enums

c117398

bilelmoussaoui force-pushed the bilelmoussaoui/update branch from fb67306 to c117398 Compare

November 5, 2020 09:34

Member

sdroege commented Nov 5, 2020

This was handled by Chris few days ago already :)

gtk-rs/gir-files#61 this one? And the bindings were simply not yet updated to that version?

Member Author

bilelmoussaoui commented Nov 5, 2020

Yes, that's it. There was an sdk update recently though, I will check if there were any changes as I need to add the necessary gir files for #37 as well

Member

sdroege commented Nov 5, 2020

Makes sense. Then get this in here once the CI is happy, the changes look good to me :)

sdroege approved these changes

View reviewed changes


          gtk4: generate snapshot_append_*_gradient manually

c91cddb

same as append_linear_gradient & append_repeating_linear_gradient

Member Author

bilelmoussaoui commented Nov 5, 2020

This looks good now :)

bilelmoussaoui merged commit 29a1c7a into master

bilelmoussaoui deleted the bilelmoussaoui/update branch

November 5, 2020 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet