Skip to content

Handle empty package namespace in package selectors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcombuechen
Copy link

Closes #85.

Solutions to the problem:

  • fall back on a non-breaking space when a namespace option label is empty
  • make the state values of package type, namespace, name nullable to better handle an unselected state

@mcombuechen
Copy link
Author

Some screenshots

a. The empty namespace option now renders more nicely:

Screenshot 2024-05-30 at 09 24 49

b. When selecting the empty namespace option, the package name selector gets enabled.

Screenshot 2024-05-30 at 09 26 58

@mcombuechen
Copy link
Author

oops I see now this is partly a duplicate of #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package dropdowns break with empty namespace
1 participant