Add switch LineItemsJobs
#27877
Merged
Add switch LineItemsJobs
#27877
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deedeeh
force-pushed
the
dina/add-switch-for-line-items-jobs-stack
branch
2 times, most recently
from
51a88eb to
3639dfd
Compare
deedeeh
force-pushed
the
dina/add-switch-for-line-items-jobs-stack
branch
from
99c4e6c to
72719cb
Compare
Jakeii
reviewed
Apr 10, 2025
Jakeii
approved these changes
Apr 11, 2025
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @deedeeh 13 minutes and 34 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Adding confidence if something went wrong with the new line items jobs (state machine generates S3 objects) we can switch off
LineItemsJobswhich means read and write from and todfp/.What does this change?
This PR adds a feature switch to the CommercialSwitches.
The following changes relies on the switch:
gam/which contains the S3 objects from the new line items jobs stack the Commercial team created.lineitems-v7.jsonandnon-refreshable-lineitem-ids-v1.jsonin other words we won't update those objects anymore as we will be using the ones from the new stack.dfp/which has the current generated S3 objects by EC2 instances.lineitems-v7.jsonandnon-refreshable-lineitem-ids-v1.jsonThe new stack currently just generates the line items and non refreshable line items ids and we will continue the work on the other json files along the way.
Checklist