Added Merchant Info to V3 Card Charge endpoint #9985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this related to a YSWS/card grant integration? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+22
to
+24
| humanized_merchant_name(merchant_data) | ||
| rescue StandardError | ||
| nil |
There was a problem hiding this comment.
Suggested change
| humanized_merchant_name(merchant_data) | |
| rescue StandardError | |
| nil | |
| humanized_merchant_name(merchant_data) | |
| rescue | |
| nil |
Comment on lines
+9
to
+10
| expose :network_id | ||
| end |
There was a problem hiding this comment.
Suggested change
| expose :network_id | |
| end | |
| expose :network_id | |
| end |
|
This is more related to a yellow page integration as it'll allow me to sift through most organizations' card charges and add network IDs that are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
I wasn't able to fetch the info of card charges via the v3 api.
Describe your changes
I added merchant info: name, smart name, country, and network id and made sure the docs reflected it elegantly